Handling of super key on other platforms #4333
Open
+29
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbasic
changed the title
emilk
reviewed
Apr 21, 2024
crates/egui/src/data/input.rs
Outdated
Comment on lines
681
to
683
| if !cfg!(target_os = "macos") { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Can't use the compile-time target_os in egui, since that won't work on wasm32. That's why we have ctx.os()
There was a problem hiding this comment.
ctx.os() didn't seem to work here.
Let me check again.
There was a problem hiding this comment.
Maybe we don't need this check at all. Let's just define mac_cmd to mean super?
There was a problem hiding this comment.
Changed to
pub fn mac_cmd_only(&self) -> bool {
self.super_only()
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handling of super key on other platforms