Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icon): more elegant, adjust the opacity of the expand button to 32% #266

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ForrestSu
Copy link

@ForrestSu ForrestSu commented Jul 18, 2023

What's this PR do?

  • adjust the opacity of the expand button to 32%

What are the relevant Git tickets?

None

Screenshots (if appropriate)

  • Bright Theme effect
image
  • Dark Theme effect
image

Any background context you want to provide? (if appropriate)

idea: less conspicuous, overall more coordinated

@jwhitley
Copy link

That looks really nice. That said, this variation measures out to a WCAG contrast of ~1.7 for both the light and dark variants – far below the accessible minimum contrast of 4.0. I.e. people with vision issues, often just due to age, won't be able to make out that icon.

My suggestion: add an option to toggle back to the original (or at least, higher) contrast icon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants