Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Windows 10 OS support. Fixes #47 #52

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

mnothh
Copy link

@mnothh mnothh commented Oct 4, 2019

Pull Request (PR) description

Added support for Windows "Client" operating systems in the
Assert-HasPrereqsForBitlocker function.

This Pull Request (PR) fixes the following issues

-Fixes #47

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@mnothh mnothh changed the title Win10 fix working branch Added Windows "Client" OS support. Fixes #47 Oct 4, 2019
@mnothh mnothh changed the title Added Windows "Client" OS support. Fixes #47 Added Windows 10 OS support. Fixes #47 Oct 4, 2019
@mnothh mnothh marked this pull request as ready for review October 4, 2019 12:22
@codecov-io
Copy link

codecov-io commented Oct 4, 2019

Codecov Report

Merging #52 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev    #52   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files         3      3           
  Lines        98     98           
===================================
  Hits         98     98           

johlju and others added 3 commits October 29, 2019 20:26
- Fix hashtables according to the style guideline.
xBitLocker: Fix hashtables according to the style guideline
@mhendric
Copy link
Contributor

mhendric commented Nov 5, 2019

Hi @mnothh , let me know if you need any help resolving the continuous intregration failures on this. Looks like it's a minor issue in the CHANGELOG.MD file. Also just FYI, I've been holding off on doing the code review on this until continuous integration passes.

Context When there are markdown files

371
VERBOSE: Using markdownlint settings file from repository folder 'C:\projects\xbitlocker'.
372
C:\projects\xbitlocker\CHANGELOG.md: 6: MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- Fixed issue causing Assert-H..."]
373
[-] Should not have errors in any markdown files 5.14s
374
Expected 0, but got 1.
375
986: $mdErrors | Should -Be 0
376
at , C:\projects\xbitlocker\DscResource.Tests\Meta.Tests.ps1: line 986

@mhendric mhendric added the waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. label Nov 5, 2019
@mhendric
Copy link
Contributor

Hi @mnothh , not sure why, but reviewable is forcing me to put my code review in #48, not #52. Can you check my code review notes at: #48 ? Thanks.

@johlju
Copy link
Member

johlju commented Jan 29, 2020

I have fixed the reviewable button on this PR so it points to the correct PR on Reviewable.

@mhendric
Copy link
Contributor

mhendric commented Jul 1, 2020

Hi @mnothh , thanks for following up on this one. I need to push through some changes to get our automated testing working again. As soon as I do, I will try to get this PR checked in.

@johlju
Copy link
Member

johlju commented Sep 9, 2020

This repository have now been updated to the new CI/CD pipeline so deploy is automatic on PR merge. This PR was re-targeted to the master branch (dev branch is not longer present). This PR need to be rebased with the changes from the master-branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource do not work on Windows 10
4 participants