Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cNtfsPermissionEntry.psm1 #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shubhamgupta514
Copy link

Do not use "APPLICATION PACKAGE AUTHORITY\ALL RESTRICTED APPLICATION PACKAGES " but "ALL RESTRICTED APPLICATION PACKAGES " only as Principal and I have done few modifications to support that cNtfsPermissionEntry DscResource.

Do not use "APPLICATION PACKAGE AUTHORITY\ALL RESTRICTED APPLICATION PACKAGES " but  "ALL RESTRICTED APPLICATION PACKAGES " only as Principal and I have done few modifications to support that cNtfsPermissionEntry DscResource.
@shubhamgupta514
Copy link
Author

@SNikalaichyk Could you review it and merge it .Please do let me know if you have any queries

@SNikalaichyk
Copy link
Contributor

Hi @shubhamgupta514, first of all thanks for submitting this PR!
This is quite a big change, and thus will require a thorough review and testing.
I would also want to get more details about the issue(s) this PR is meant to address.
After a quick look:

  • The code needs to match the overall formatting style, look, and feel of the module.
  • The Convert-FileSystemRightsInteger function needs to have tests and follow the style as it's very messy (aliases, lots of comments etc).

@shubhamgupta514
Copy link
Author

@SNikalaichyk Thanks for your comments.

I am not the original author of Convert-FileSystemRightsInteger. I copied the source code from Technet and already mentioned the link for the same as comment above the function.

@shubhamgupta514
Copy link
Author

About the PR, I am getting an error "Some or all identity references could not be translated" I am trying modifying the permissions for APPLICATION PACKAGE AUTHORITY\ALL RESTRICTED APPLICATION PACKAGES on a particular file or folder.

What I found after some debugging if we only use "ALL RESTRICTED APPLICATION PACKAGES" without the domain and use of the sid of the same in access rule as an argument in modifyaccessrule. Everything is working fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants