Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UpdateServicesServer, UpdateServicesApprovalRule: Fixing Products processing, verbose output #64

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

MartinVokurek
Copy link

@MartinVokurek MartinVokurek commented Feb 12, 2021

Pull Request (PR) description

  • Fixed UpdateServicesServer and UpdateServicesApprovalRule
    • Process multiple product categories with the same name correctly (e.g. "Windows Admin Center")
    • Verbose output of Products only displayed one product
  • Fixed verbose output of Languages in UpdateServiceServer
  • Fixed verbose output of WSUS server in UpdateServicesApprovalRule

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@MartinVokurek
Copy link
Author

I think I'll need a bit of advice on how to deal with all the failed checks, as they seem to be mostly unrelated to the changes that I made. Should I ignore them? Or do they need to be fixed first, before my changes can be accepted?

Copy link

@daemenseth daemenseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested looks good

daemenseth
daemenseth previously approved these changes Apr 9, 2021
Copy link

@daemenseth daemenseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. tested->ok

@daemenseth
Copy link

Project likes dead. How can we made progression in it that the pull request are approved?

@luzkenin
Copy link

Is this project abandoned?

@gaelcolas
Copy link
Member

No, but I need to be reminded (on slack) or see the notifications.
We also need more reviewers that can eventually help maintain the repo.
I'll try to have a look this weekend.

@TheBlackMini
Copy link

Curious if this PR will be merged?

@gaelcolas
Copy link
Member

@NicolasBn has this been included part of your merged changes?

@gaelcolas
Copy link
Member

@TheBlackMini or @luzkenin are you able to rebase this branch and re-submit a PR.

@NicolasBn
Copy link
Member

@gaelcolas Indeed. To cover issue #61, I need to update UpdateServicesApprovalRule resource.

@TheBlackMini
Copy link

So, @NicolasBn do I need to do anything?

@NicolasBn
Copy link
Member

@TheBlackMini I don't have any time before next week. If you don't want to wait, you can submit your PR :)

@NicolasBn
Copy link
Member

NicolasBn commented Feb 17, 2023

I worked on a solution here : Get-UpdateServicesDscProduct

I created a function to find all products based on value passed on Products property.

I 'just' need to use it in UpdateServicesApprovalRule, and adapt pester tests.
It was a few month ago. So I need times to reintegrate my code :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants