OfficeOnlineServerHost: New resource proposal

[JonasCassier]

Pull Request (PR) description

OfficeOnlineServerHost: New resource proposal

This Pull Request (PR) fixes the following issues

• Fixes OfficeOnlineServerHost: New resource proposal #62

Task list

• Added an entry to the change log under the Unreleased section of the
  file CHANGELOG.md. Entry should say what was changed and how that
  affects users (if applicable), and reference the issue being resolved
  (if applicable).
• Resource documentation added/updated in README.md.
• Resource parameter descriptions added/updated in README.md, schema.mof
  and comment-based help.
• Comment-based help added/updated.
• Localization strings added/updated in all localization files as appropriate.
• Examples appropriately added/updated.
• Unit tests added/updated. See DSC Community Testing Guidelines.
• Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
• New/changed code adheres to DSC Community Style Guidelines.

---

This change is 

[johlju]

I think this resource would be better if it instead of AllowList had the parameters Domains, DomainsToInclude and DomainsToExclude. Using the parameter Domains would override (remove) any already configured domains, passing an empty array would remove any configured domains (if. that is a possible scenario). The parameter DomainsToExclude would remove any domain that is present, and leave the rest. The parameter DomainsToInclude would add any domain that is not present, and leave the rest.

I think parameter Ensure should not be used in this resource as Ensure normally is used when ensuring one object can only be present or absent, for example one host domain, one user account, etc. It would also be strange if there is another property is added to the resource, what property would you then want to ensure is present or absent. 🙂

[JonasCassier]

I have adapted the resource according to your suggestions.
Can you please take another look? I still need to change the unit tests.

[johlju]

I see duplicate files. It seems you have copied the resource folder into the resource folder (duplicate folder names here): src/DSCResources/MSFT_OfficeOnlineServerHost/MSFT_OfficeOnlineServerHost/MSFT_OfficeOnlineServerHost.psm1

I will review as soon as I have time.

Reviewable status: 0 of 12 files reviewed, all discussions resolved

[JonasCassier]

Thx. I have removed the duplicate folder.

[johlju]

@JonasCassier I merged a PR updating all the pipeline files, so if your rebase the pipeline in this PR should run correctly.

[johlju]

Still to many files because you have no remote to the upstream repo that have the new changes, So in your case you need another remote for the upstream to be able to get them down to you local repository.

I think this should work for you, let me know if anything fails:

# add remote to upstream
git remote add upstream https://github.com/dsccommunity/OfficeOnlineServerDsc.git

# fetch changes from upstream branch master
git fetch upstream master

# rebase the local repository branch master
git checkout master
git rebase upstream/master

# push the updated branch master to your forked GitHub repository
git push origin --force

# Rebase the working (PR) branch using the updated local branch master
git checkout Feature/OfficeWebAppsHost
git rebase upstream/master

# Fix any conflicts as you did before

# When there are no more conflicts, run the following to update the working branch in your forked GitHub repository (which will update the PR)
git push origin --force

[JonasCassier]

@johlju I got into a mess of merge conflicts, so I created a new Branch:

git checkout master
Already on 'master'
Your branch is up to date with 'origin/master'.

git fetch upstream master
From https://github.com/dsccommunity/OfficeOnlineServerDsc

• branch master -> FETCH_HEAD

git checkout master
Already on 'master'
Your branch is up to date with 'origin/master'.

git rebase upstream/master
Current branch master is up to date.

git push origin --force
Everything up-to-date
git branch Feature/OfficeOnlineServerHost
git checkout Feature/OfficeOnlineServerHost

Here is the new PR #66

[JonasCassier]

duplicates #66