New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OfficeOnlineServerFarm: Added hierarchy and LDAP:// support for FarmOU #59
base: master
Are you sure you want to change the base?
OfficeOnlineServerFarm: Added hierarchy and LDAP:// support for FarmOU #59
Conversation
@ykuijs Will it be possible to include this improvement anytime soon? |
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @jensotto)
a discussion (no related file):
We are gonna need a unit test for this change.
src/Modules/OfficeOnlineServerDsc.Util/OfficeOnlineServerDsc.Util.psm1
line 352 at r2 (raw file):
$adsi = [adsisearcher]'(objectCategory=organizationalUnit)' $searchRoot = "," + $adsi.SearchRoot.Path -replace 'LDAP://'
Since I cannot determine if this change would break anything or actually make the resource work better, I would really like someone to verify that this change do not break existing functionality (existing configurations). 🙂
Sorry @johlju I don't have the environment for this available anymore. I don't expect that I will be able to contribute much to this right now as my focus is elsewhere. All I can say is that the changes worked fine in a manually edited version of this module with the suggested changes on the server used for OOS. |
No worries, I understand. I will label this as abandond so another contributor can take over to verify this. I'm sure the code worked for you in your scenario, but I worried it will break existing configurations in other scenarios. |
Pull Request (PR) description
Added support for specifying LDAP:// syntax and OU hierarchy for FarmOU
It's now possible to specify FarmOU like this:
"Servers/OOS" or
"ldap://OU=OOS,OU=Servers"
ntds:// format is supported by the underlying Office Online Server Management Shell but is not implemented in OfficeOnlineServerDSC.
This Pull Request (PR) fixes the following issues
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
and comment-based help.
This change is