Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADDomain: Fix DNS Delegation issue #635

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nanderh
Copy link

@nanderh nanderh commented Nov 25, 2020

Added fix for issue #176 , DNS Delegation not included in ADDomain. And incorporated fix from ansible/ansible#39235

Pull Request (PR) description

Added fix for above issues by:

  • Adding InstallDNS switch if the DnsDelegationCredential option has been used
  • Starting the netlogon service after domain installation

This Pull Request (PR) fixes the following issues

Fixes issue #176 ADDomain: DNS Delegation is no longer working.

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

Added fix for issue dsccommunity#176 , DNS Delegation not included in ADDomain. And incorporated fix from ansible/ansible#39235
@johlju johlju added the needs review The pull request needs a code review. label Nov 28, 2020
@X-Guardian
Copy link
Contributor

@nanderh, thanks for your contribution and raising this PR. The CI checks are currently failing for it, as you need to update the changelog, and modify the ADDomain resource unit tests to support this change.

@johlju johlju changed the base branch from master to main January 5, 2021 16:33
@X-Guardian X-Guardian added waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. and removed needs review The pull request needs a code review. labels May 16, 2021
@stale
Copy link

stale bot commented May 30, 2021

Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again.

@stale stale bot added the abandoned The pull request has been abandoned. label May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abandoned The pull request has been abandoned. waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants