Net9 Reference Assemblies #73423

jaredpar · 2024-05-10T16:21:42Z

This adds the .NET 9 reference assemblies into our test harness.

jaredpar · 2024-05-10T16:22:06Z

eng/Directory.Packages.props

+    <PackageVersion Include="Basic.Reference.Assemblies.Net80" Version="1.7.2" />
+    <PackageVersion Include="Basic.Reference.Assemblies.Net461" Version="1.7.2" />
+    <PackageVersion Include="Basic.Reference.Assemblies.NetStandard13" Version="1.7.2" />
+    <PackageVersion Include="Basic.Reference.Assemblies.Net90" Version="1.7.2" />


@jcouv this new version also has the XML doc comments that you asked for in the last update. #Closed

jaredpar · 2024-05-10T16:22:24Z

@dotnet/roslyn-compiler PTAL
@AlekseyTs FYI

jcouv · 2024-05-10T17:06:47Z

eng/Directory.Packages.props

-    <PackageVersion Include="Basic.Reference.Assemblies.Net80" Version="1.4.5" />
-    <PackageVersion Include="Basic.Reference.Assemblies.Net461" Version="1.6.0" />
-    <PackageVersion Include="Basic.Reference.Assemblies.NetStandard13" Version="1.6.0" />
+    <PackageVersion Include="Basic.Reference.Assemblies.NetStandard20" Version="1.7.2" />


1.7.2

Would it make sense to abstract this version number so that we can upgrade from just one location? #Closed

Yeah that would make sense now that I've unified them all.

jcouv · 2024-05-10T17:07:46Z

src/Compilers/Test/Core/TargetFrameworkUtil.cs

@@ -91,7 +91,8 @@ public enum TargetFramework
        Net50,
        Net60,
        Net70,
-        Net80
+        Net80,
+        Net90,


Consider adding a test or upgrading an existing one to exercise this new TFM #Closed

All the places for the new tests are in the ref generic interfaces branch. For merge purposes it's better to have the initial commit here. Once Aleksey merges this in we'll move to this TFM. If there are any issues I will deal with the fallout.

jcouv

Done with review pass (iteration 3)

jcouv

LGTM Thanks (iteration 4)

jjonescz · 2024-05-10T18:26:03Z

src/Compilers/Test/Core/TargetFrameworkUtil.cs

@@ -292,6 +293,7 @@ static TargetFrameworkUtil()
            TargetFramework.Net60 => ImmutableArray.CreateRange<MetadataReference>(LoadDynamicReferences("Net60")),
            TargetFramework.NetCoreApp or TargetFramework.Net70 => ImmutableArray.CreateRange<MetadataReference>(Net70.References.All),
            TargetFramework.Net80 => ImmutableArray.CreateRange<MetadataReference>(LoadDynamicReferences("Net80")),
+            TargetFramework.Net90 => ImmutableArray.CreateRange<MetadataReference>(LoadDynamicReferences("Net90")),


Why are tests failling if this isn't used anywhere?

Example test failure in Microsoft.CodeAnalysis.CSharp.UnitTests.CollectionExpressionTests.SpanArgument_01(targetFramework: Net80):

++> IL_001d: newobj "System.ReadOnlySpan<int?>..ctor(ref readonly int?)" --> IL_001d: newobj "System.ReadOnlySpan<int?>..ctor(in int?)"

Hmm ... that is odd.

The tests all pass when run individually but fail when the entire test class is executed. We must be holding onto state somewhere

I do not see a single line in CollectionExpressionTests that starts with IL_001d: newobj. What am I missing?

Regarding the diff, is it possible that we are updated to ref assembly for 8.0 that use ref readonly in the constructor?

@jaredpar

The tests all pass when run individually but fail when the entire test class is executed. We must be holding onto state somewhere

It is likely that CI failures are expected given the changes to ref assemblies that you are making. It looks to me like your branch is behind main enough to make the difference between the local state and the merged state the CI is running against. That is why CI failures do not make sense in context of your local branch. Consider merging main into you branch, then running tests locally.

Figured out what is happening here. When I updated the reference assemblies recently I missed updating the net80 set. That means the NuPkg remained at 1.4.5 which is based off of the 8.0.0-preview.7.23375.6 version of .NET. The ref readonly parameter changes came in after that. Now that I unified the versions into a single MSBuild prop that dragged the net80 version forward to RTM and we're seeing the signature differences.

alrz · 2024-05-11T07:56:59Z

Kind of tangential, but how to avoid building the project for every TFM when building locally? Is there a quick way to limit tests/build to only one framework by default?

AlekseyTs · 2024-05-14T19:48:57Z

<TargetFrameworks>$(NetRoslyn);net472</TargetFrameworks>

@jaredpar I think we should change this to net9.0. Otherwise test scenarios using TargetFramework.Net90 won't execute. #Closed

Refers to: src/Compilers/CSharp/Test/Emit3/Microsoft.CodeAnalysis.CSharp.Emit3.UnitTests.csproj:7 in 7c5510e. [](commit_id = 7c5510e, deletion_comment = False)

AlekseyTs · 2024-05-14T19:51:21Z

<TargetFrameworks>$(NetRoslyn);net472</TargetFrameworks>

Or did you plan to do this later, in RefstructInterfaces branch?

In reply to: 2111024335

Refers to: src/Compilers/CSharp/Test/Emit3/Microsoft.CodeAnalysis.CSharp.Emit3.UnitTests.csproj:7 in 53640ea. [](commit_id = 53640ea, deletion_comment = False)

AlekseyTs · 2024-05-14T19:54:29Z

<TargetFrameworks>$(NetRoslyn);net472</TargetFrameworks>

A change like that causes: "C:\Program Files\dotnet\sdk\8.0.104\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.TargetFrameworkInference.targets(166,5): error NETSDK1045: The current .NET SDK does not support targeting .NET 9.0. Either target .NET 8.0 or lower, or use a version of the .NET SDK that supports .NET 9.0. Download the .NET SDK from https://aka.ms/dotnet/download"

In reply to: 2111027934

Refers to: src/Compilers/CSharp/Test/Emit3/Microsoft.CodeAnalysis.CSharp.Emit3.UnitTests.csproj:7 in 53640ea. [](commit_id = 53640ea, deletion_comment = False)

jaredpar · 2024-05-14T20:43:14Z

@AlekseyTs

Or did you plan to do this later, in RefstructInterfaces branch?

This. Moving to a new net9.0 inside our project files is a fairly big change. I wanted to separate out making the new reference assemblies available and moving to the new TFM.

AlekseyTs

LGTM (commit 5)

jaredpar requested review from a team as code owners May 10, 2024 16:21

dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels May 10, 2024

jaredpar commented May 10, 2024

View reviewed changes

AlekseyTs approved these changes May 10, 2024

View reviewed changes

jcouv self-assigned this May 10, 2024

jcouv reviewed May 10, 2024

View reviewed changes

jcouv approved these changes May 10, 2024

View reviewed changes

jjonescz reviewed May 10, 2024

View reviewed changes

jaredpar mentioned this pull request May 13, 2024

net9.0 reference assemblies #73454

Closed

jaredpar added 5 commits May 14, 2024 13:39

net9.0 preview3

47e22af

more

a8dbe48

more

0919556

pr feedback

7038cfa

fix baselines

7c5510e

jaredpar force-pushed the net9 branch from 53640ea to 7c5510e Compare May 14, 2024 20:49

AlekseyTs approved these changes May 14, 2024

View reviewed changes

jaredpar merged commit 0a0da2d into dotnet:main May 14, 2024
26 of 28 checks passed

jaredpar deleted the net9 branch May 14, 2024 22:51

dotnet-policy-service bot added this to the Next milestone May 14, 2024

dotnet-bot mentioned this pull request May 16, 2024

[Automated] PRs inserted in VS build main-34915.83 #73499

Closed

dotnet-bot mentioned this pull request May 21, 2024

[Automated] PRs inserted in VS build feature.debugger.main-34920.221 #73610

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Net9 Reference Assemblies #73423

Net9 Reference Assemblies #73423

jaredpar commented May 10, 2024

jaredpar May 10, 2024 •

edited by jcouv

jaredpar commented May 10, 2024

jcouv May 10, 2024 •

edited

jaredpar May 10, 2024

jcouv May 10, 2024 •

edited

jaredpar May 10, 2024

jcouv left a comment

jcouv left a comment

jjonescz May 10, 2024

jaredpar May 10, 2024

jaredpar May 13, 2024

AlekseyTs May 13, 2024 •

edited

AlekseyTs May 14, 2024

jaredpar May 14, 2024

alrz commented May 11, 2024

AlekseyTs commented May 14, 2024 •

edited

AlekseyTs commented May 14, 2024

AlekseyTs commented May 14, 2024

jaredpar commented May 14, 2024

AlekseyTs left a comment

@@ @@ -91,7 +91,8 @@ public enum TargetFramework @@
                       Net50,
                       Net60,
                       Net70,
-                      Net80
+                      Net80,
+                      Net90,

Net9 Reference Assemblies #73423

Net9 Reference Assemblies #73423

Conversation

jaredpar commented May 10, 2024

jaredpar May 10, 2024 • edited by jcouv

Choose a reason for hiding this comment

jaredpar commented May 10, 2024

jcouv May 10, 2024 • edited

Choose a reason for hiding this comment

jaredpar May 10, 2024

Choose a reason for hiding this comment

jcouv May 10, 2024 • edited

Choose a reason for hiding this comment

jaredpar May 10, 2024

Choose a reason for hiding this comment

jcouv left a comment

Choose a reason for hiding this comment

jcouv left a comment

Choose a reason for hiding this comment

jjonescz May 10, 2024

Choose a reason for hiding this comment

jaredpar May 10, 2024

Choose a reason for hiding this comment

jaredpar May 13, 2024

Choose a reason for hiding this comment

AlekseyTs May 13, 2024 • edited

Choose a reason for hiding this comment

AlekseyTs May 14, 2024

Choose a reason for hiding this comment

jaredpar May 14, 2024

Choose a reason for hiding this comment

alrz commented May 11, 2024

AlekseyTs commented May 14, 2024 • edited

AlekseyTs commented May 14, 2024

AlekseyTs commented May 14, 2024

jaredpar commented May 14, 2024

AlekseyTs left a comment

Choose a reason for hiding this comment

jaredpar May 10, 2024 •

edited by jcouv

jcouv May 10, 2024 •

edited

jcouv May 10, 2024 •

edited

AlekseyTs May 13, 2024 •

edited

AlekseyTs commented May 14, 2024 •

edited