Add dynamic registration for razor and cshtml files #73369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
3 tasks
davidwengier
approved these changes
May 8, 2024
dibarbet
requested changes
May 8, 2024
| [ExportCSharpVisualBasicLspServiceFactory(typeof(OnInitialized)), Shared] | ||
| [method: ImportingConstructor] | ||
| [method: Obsolete(MefConstruction.ImportingConstructorMessage, error: true)] | ||
| internal sealed class DynamicDocumentSyncRegistration() : ILspServiceFactory |
There was a problem hiding this comment.
I think I'd prefer this to be in the main language server project. We can check if devkit is enabled using a global option, but maybe we should just have it always be on too.
There was a problem hiding this comment.
Do you just want it next to the sync handlers?
There was a problem hiding this comment.
If we put it in the protocol project, it will light up in VS. If you want that, then yes. Otherwise put it in the LanguageServer.csproj project (probably in the language server folder).
This is the devkit global option - https://github.com/dotnet/roslyn/blob/main/src/Features/LanguageServer/Protocol/LspOptionsStorage.cs#L31
dibarbet
approved these changes
May 9, 2024
...Microsoft.CodeAnalysis.LanguageServer/LanguageServer/RazorDynamicDocumentSyncRegistration.cs
Outdated
Show resolved
Hide resolved
…ver/LanguageServer/RazorDynamicDocumentSyncRegistration.cs Co-authored-by: David Barbet <dibarbet@gmail.com>
This was referenced May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.