-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow access modifiers to auto properties getters and setters #16861
base: main
Are you sure you want to change the base?
Allow access modifiers to auto properties getters and setters #16861
Conversation
…om/Tangent-90/fsharp into access-modifies-to-auto-properties
❗ Release notes required
|
|
I make the new signature generation way under the |
@Tangent-90 , will you have time to fix the conflict here? It's pretty simple, but probably best to do it locally and have the .xlf files be generated again (instead of doing it manually) |
Maybe two days later |
Hey @Tangent-90, awesome work! For posterity, can you link the RFC and the original discussion in the top (i.e., in your original description)? It's kinda hidden behind several other issues now. For your convenience, just copy/paste: * [Original suggestion](https://github.com/fsharp/fslang-suggestions/issues/430)
* [RFC](https://github.com/fsharp/fslang-design/pull/764)
* [Previous merged work](https://github.com/dotnet/fsharp/pull/16687) (you may also delete the Release notes comments in the OP, these are just from the PR template and add clutter ;) |
Updated. Thanks. ❤❤❤ |
Description
Fixes #16854
Checklist