-
-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake: install doctest_with_main as a target if built #837
base: dev
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #837 +/- ##
=======================================
Coverage 92.11% 92.11%
=======================================
Files 2 2
Lines 2168 2168
=======================================
Hits 1997 1997
Misses 171 171 ☔ View full report in Codecov by Sentry. |
@onqtam I am not sure about the CI failures I am seeing, they mostly seem independent from my change... ? |
Hey, I'm simply unable to review the PR appropriately at this time. Also, it's directed towards the |
This change allows installing and exporting the static library target doctest::doctest_with_main if the project is configured with DOCTEST_WITH_MAIN_IN_STATIC_LIB. This is required for usage in third-party projects that install doctest at the package-manager level.
@onqtam I rebased on top of Who would be able to review this small change? |
Not sure... see this for context: #554 (comment) |
Description
This change allows installing and exporting the static library target doctest::doctest_with_main if the project is configured with DOCTEST_WITH_MAIN_IN_STATIC_LIB.
This is required for usage in third-party projects that install doctest at the package-manager level.
GitHub Issues