Feat react template compiler #1469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to feat-react-template-compiler
…to feat-react-template-compiler
…to feat-react-template-compiler
Feat add RN Components
hiyuki
reviewed
May 31, 2024
| } | ||
| }, [isWidthFixMode, isHeightFixMode, isCropMode, src]) | ||
|
|
||
| useEffect(() => loadImage(), [loadImage]) |
There was a problem hiding this comment.
为啥以loadImage为依赖，唯一的依赖应该是src
hiyuki
reviewed
May 31, 2024
| const loadImage = useCallback((): void => { | ||
| if (!isWidthFixMode && !isHeightFixMode && !isCropMode) return | ||
| if (typeof src === 'string') { | ||
| RNImage.getSize(src, (width: number, height: number) => { |
There was a problem hiding this comment.
对于依赖图形原始高宽的mode来说，在获取图像原始高宽之前先不展示图片
hiyuki
reviewed
May 31, 2024
| applyHoverEffect && hoverStyle, | ||
| ]}> | ||
| {loading && <Loading alone={!React.Children.count(children)} />} | ||
| <Text |
There was a problem hiding this comment.
button内部可能存在非字符串的情况，比如<button><image src="..."/>xxx</button>，不能一律使用Text包裹，需要判断情况，当children.every(child=>isText(child))时才能安全使用Text包裹，逻辑可以参考群峰的view分支
hiyuki
reviewed
May 31, 2024
| ...inheritTextStyle | ||
| } | ||
| } | ||
| }, [type, plain, applyHoverEffect, loading, disabled, style]) |
fix: 小程序事件绑定
feat(View): add view component style.
hiyuki
approved these changes
Jun 4, 2024
hiyuki
reviewed
Jun 4, 2024
| }, {}) | ||
| } | ||
|
|
||
| const isText = (ele: ReactElement) => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.