Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move guard clause helpers to detekt-rules-style #7309

Merged
merged 1 commit into from
May 20, 2024

Conversation

3flex
Copy link
Member

@3flex 3flex commented May 19, 2024

These are only used in two rules and have limited utility elsewhere.

Technically a breaking change but very unlikely to be used in any third party rules.

These are only used in two rules and have limited utility elsewhere
@detekt-ci
Copy link
Collaborator

Warnings
⚠️ It looks like this PR contains functional changes without a corresponding test.

Generated by 🚫 dangerJS against d2754f2

Copy link

codecov bot commented May 19, 2024

Codecov Report

Attention: Patch coverage is 38.46154% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 84.79%. Comparing base (1b00a0c) to head (d2754f2).

Files Patch % Lines
...in/io/gitlab/arturbosch/detekt/rules/style/Junk.kt 38.46% 0 Missing and 8 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7309      +/-   ##
============================================
+ Coverage     84.76%   84.79%   +0.02%     
  Complexity     3992     3992              
============================================
  Files           578      577       -1     
  Lines         12026    12026              
  Branches       2477     2479       +2     
============================================
+ Hits          10194    10197       +3     
+ Misses          606      598       -8     
- Partials       1226     1231       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@3flex 3flex added this to the 2.0.0 milestone May 19, 2024
@3flex 3flex merged commit a116926 into detekt:main May 20, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants