Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove KtNamedDeclaration.identifierName() #7308

Merged
merged 1 commit into from
May 21, 2024

Conversation

3flex
Copy link
Member

@3flex 3flex commented May 19, 2024

This function does not provide value over using the name directly.

@detekt-ci
Copy link
Collaborator

detekt-ci commented May 19, 2024

Warnings
⚠️ It looks like this PR contains functional changes without a corresponding test.

Generated by 🚫 dangerJS against d9e94db

@3flex 3flex added the breaking change Marker for breaking changes which should be highlighted in the changelog label May 19, 2024
Copy link

codecov bot commented May 19, 2024

Codecov Report

Attention: Patch coverage is 17.39130% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 84.66%. Comparing base (6864037) to head (d9e94db).
Report is 1 commits behind head on main.

Files Patch % Lines
...rbosch/detekt/rules/naming/ObjectPropertyNaming.kt 0.00% 0 Missing and 3 partials ⚠️
...osch/detekt/rules/naming/TopLevelPropertyNaming.kt 0.00% 0 Missing and 3 partials ⚠️
...rturbosch/detekt/rules/naming/util/ExcludeClass.kt 0.00% 0 Missing and 2 partials ⚠️
...rbosch/detekt/rules/AllowedExceptionNamePattern.kt 0.00% 0 Missing and 1 partial ⚠️
...bosch/detekt/rules/naming/BooleanPropertyNaming.kt 0.00% 0 Missing and 1 partial ⚠️
...tlab/arturbosch/detekt/rules/naming/ClassNaming.kt 0.00% 0 Missing and 1 partial ⚠️
...itlab/arturbosch/detekt/rules/naming/EnumNaming.kt 0.00% 0 Missing and 1 partial ⚠️
...bosch/detekt/rules/naming/FunctionNameMaxLength.kt 50.00% 0 Missing and 1 partial ⚠️
...bosch/detekt/rules/naming/FunctionNameMinLength.kt 50.00% 0 Missing and 1 partial ⚠️
...sch/detekt/rules/naming/FunctionParameterNaming.kt 0.00% 0 Missing and 1 partial ⚠️
... and 4 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7308      +/-   ##
============================================
- Coverage     84.78%   84.66%   -0.13%     
- Complexity     3993     4001       +8     
============================================
  Files           576      575       -1     
  Lines         12021    12024       +3     
  Branches       2478     2483       +5     
============================================
- Hits          10192    10180      -12     
  Misses          598      598              
- Partials       1231     1246      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@3flex 3flex added this to the 2.0.0 milestone May 19, 2024
This function does not provide value over using the `name` directly.
@3flex 3flex force-pushed the remove-KtNamedDeclaration.identifierName branch from 1064e51 to d9e94db Compare May 21, 2024 03:14
@3flex 3flex enabled auto-merge (squash) May 21, 2024 03:15
@3flex 3flex merged commit 21cb208 into detekt:main May 21, 2024
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api breaking change Marker for breaking changes which should be highlighted in the changelog rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants