Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster InvalidPackageDeclaration #7273

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BraisGabin
Copy link
Member

We know that visit a KtFile is not free at all. But we don't have any values to see if this is really faster or not.

My next project on detekt is going to be a tool to monitor the detekt performance. Once we have that we could take a look at the Rule implementation because I think that it pushes to overuse the visit pattern everywhere even in cases that is not needed (for example the one of this PR)

I left this PR as draft because I want to know how much faster is InvalidPackageDeclaration with this change.

@detekt-ci detekt-ci added the rules label May 8, 2024
@detekt-ci
Copy link
Collaborator

Warnings
⚠️ It looks like this PR contains functional changes without a corresponding test.

Generated by 🚫 dangerJS against b1f69a4

Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 84.74%. Comparing base (bf3fc6f) to head (b1f69a4).

Files Patch % Lines
...h/detekt/rules/naming/InvalidPackageDeclaration.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7273      +/-   ##
============================================
- Coverage     84.75%   84.74%   -0.01%     
  Complexity     3992     3992              
============================================
  Files           578      578              
  Lines         12027    12027              
  Branches       2485     2485              
============================================
- Hits          10193    10192       -1     
  Misses          606      606              
- Partials       1228     1229       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants