Allow using env vars in the driver config file #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay, turns out this doesn't necessarily work as I expected, since with the current chart the env tag in the config file gets removed (presumably because Helm is trying to parse it and has no idea what it is). This would probably require some fixes on the chart side, but I'll wait with that to get an opinion from the maintainers, since I'm not sure if I'm going in a right direction with this. |
This commit makes it possible to use environment variables in the driver
configuration file, using the `{env:<environment variable name>}`
format.
LiquidPL
force-pushed
the
env-yaml-tag
branch
2 times, most recently
from
71af3e5
to
4f817c3
Compare
|
I have changed this to not use YAML tags, since this approach proved problematic when applying the config using a Helm chart, now it is handled using a simple string substitution, for instance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #400.