Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: I save the initial full time and set the final result with #1757 #3808

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Tiago-Silva
Copy link

Solving issue #1757 which was returning the time to zero.
Now I save the start time and then set the final result with the start time.

close: #1757

@Tiago-Silva Tiago-Silva reopened this May 18, 2024
Copy link

@JhonySpark JhonySpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still in doubt if its best solution, i'll let a request changes for comment and will wait for another review.

@@ -22,10 +23,20 @@ import { setISOWeekYear } from "../setISOWeekYear/index.js";
* // Add 5 ISO week-numbering years to 2 July 2010:
* const result = addISOWeekYears(new Date(2010, 6, 2), 5)
* //=> Fri Jn 26 2015 00:00:00
* I save the initial full time and set the final result with that initial time

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this comment should removed.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @JhonySpark;
I removed the comment as suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

addISOWeekYears resets times to 0:00:00
2 participants