[DS][x/n] Combine operands and operators folders into impls #21955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 17, 2024
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @OwenKephart and the rest of your teammates on |
OwenKephart
changed the title
OwenKephart
force-pushed
the
05-17-ScheduledSince_condition_instead_of_ScheduledSince_delta
branch
from
225f872
to
2e0af0b
Compare
OwenKephart
force-pushed
the
05-17-Combine_operands_and_operators_folders
branch
from
58836de
to
e76d7c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
As title -- as I've been developing here, the distinction between these two categories of conditions has not felt significant enough to warrant splitting them out into separate folders. I find it easier to think about / find the code I'm looking for if there's just a single place to look for "implementations".
How I Tested These Changes