Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC replace copy_py alias by a function #21948

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mlarose
Copy link
Contributor

@mlarose mlarose commented May 17, 2024

TL;DR

The copy_py alias is not recognized in some environments, and the script is unusable as it fails to rsync the desired files.

This change replaces it with a more readily supported bash function

Copy link
Contributor Author

mlarose commented May 17, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @mlarose and the rest of your teammates on Graphite Graphite

@mlarose mlarose changed the title feat: replace copy_to alias by a function RFC replace copy_to alias by a function May 17, 2024
@mlarose mlarose requested a review from gibsondan May 17, 2024 20:18
@mlarose mlarose marked this pull request as ready for review May 17, 2024 20:19
@mlarose mlarose changed the title RFC replace copy_to alias by a function RFC replace copy_py alias by a function May 17, 2024
@@ -31,14 +31,18 @@ if [[ -z ${DAGSTER_UI_DONT_BUILD_JS_BUNDLE+x} ]]; then
fi

echo -e "--- \033[32m:truck: Copying files...\033[0m"
alias copy_py="rsync -av \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shopt -s expand_alias would need to go as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would replace other instances as well if any, just fishing for alignment here.

@gibsondan
Copy link
Member

what environments does it not work in?

can you re-submit with "NO_SKIP" in the commit message so that buildkite actually runs the test that uses this to make sure this works there?

I think i copied this pattern from elsewhere, i definitely did not invent this macro (i think it is used elsewhere)

@mlarose
Copy link
Contributor Author

mlarose commented May 20, 2024

what environments does it not work in?

can you re-submit with "NO_SKIP" in the commit message so that buildkite actually runs the test that uses this to make sure this works there?

I think i copied this pattern from elsewhere, i definitely did not invent this macro (i think it is used elsewhere)

macosx ohmyzsh mostly as proposed in the eng onboarding doc - a few plugins and not much else i don't think I have anything fancy going on and after trying 2-3 things, I just decided to replace the alias. it's not the most portable approach vs a bash function. My rationale in not putting any effort to fix my environment is that this is an OSS project and we shouldn't expect all OSS to normalize their environment for something that is easily made cross compatible.

in some environment, the script will not work as the alias copy_to is not recognize.
@mlarose mlarose force-pushed the mlarose/build-without-alias branch from 0b54df0 to 5f6c26b Compare May 21, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants