-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add multi-lang module structure page #7411
docs: Add multi-lang module structure page #7411
Conversation
b707e5a
to
6c56fa2
Compare
This was a difficult page to merge, because the content was significantly different for each languages. I needed to backfill some content and also adjust the structure of the sections. To confirm there are no errors, I would like review and approval from experts in our team. Pinging: When reviewing, if you see areas where we can modify or optimize the internal page structure further, please add comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these changes, I added some update suggestions based on new changes that were introduced with #7096.
I like the overall structure, you found a nice balance between generic information and language specific.
"devDependencies": { | ||
"@dagger.io/dagger": "./sdk" | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changed with #7096 in favor of
{
"dependencies": {
"typescript": "^5.3.2"
"@dagger.io/dagger": "./sdk"
}
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
|
||
```shell | ||
# executed by the runtime container | ||
npm install --package-lock-only ./sdk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changed with #7096, now we install the SDK using yarn v4
and add the dependencies to the package.json
with npm pkg set "dependencies[@dagger.io/dagger]=./sdk"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added, please check if correct
</TabItem> | ||
<TabItem value="TypeScript"> | ||
|
||
The runtime container is currently hardcoded to run in Node.js 21.3 (although this may be configurable in future). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will change soon when we will use LTS version, see #7433
|
||
```shell | ||
# executed by the runtime container | ||
npm install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since #7096 yarn install --production
Note that now, only production dependencies will be installed, not packages defined in the devDependencies
field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
9e9e3ae
to
3027031
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One change in comment
53c74ae
to
f184034
Compare
Signed-off-by: Vikram Vaswani <vikram@dagger.io>
Signed-off-by: Vikram Vaswani <vikram@dagger.io>
f184034
to
80e44bc
Compare
No description provided.