-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration of podman with buildroot #22704
Integration of podman with buildroot #22704
Conversation
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: manunixgit The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ephemeral COPR build failed. @containers/packit-build please check. |
Cockpit tests failed for commit d12ebac. @martinpitt, @jelly, @mvollmer please check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR! The big question here is, what is buildroot, and why does Podman need to support it upstream and in top-level files? Secondary question is, who will support this when it breaks or needs new functionality?
A couple of comments inline, but those are just general - no need to address them until the questions above are answered.
# | ||
################################################################################ | ||
|
||
PODMAN_VERSION = 5.0.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sort of thing is not done. A version string in any project is defined exactly once, in only one place, and never duplicated. Anything that references that version string shall obtain it from the One True Source. In our repo, the convention is something along these lines:
grep '^const RawVersion' version/rawversion/version.go | cut -d\" -f2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternative: Compile and run test/version//version
, it will output the version number w/o any need to maintain grep's interpretation of golang. Though it's unlikely to change, so grep is probably fine for now.
@@ -0,0 +1,3 @@ | |||
config BR2_PACKAGE_PODMAN | |||
bool "podman" | |||
depends on BR2_TOOLCHAIN_HAS_THREADS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All lines must end in \n
Agree with @edsantiago here. @manunixgit Buildroot is probably a very generic term and it's hard to see where and how it will be used from the commit message and diff. And we'd also need to know about maintainer commitment and availability before accepting this. |
This packaging information should go in Buildroot, rather than in the upstream repository... Like: https://github.com/buildroot/buildroot/tree/master/package/docker-engine (and so on) EDIT: upstream/downstream confusion The .mk is more like a .spec, if it helps See https://buildroot.org/contribute.html But you can also add it to your own project. |
Thanks for the info @afbjorklund . Adding it to the buildroot project seems fine by me if someone wants to.
Rather not, unless
|
I did not mean for podman upstream, I meant that the buildroot user can add their own packages using "external" https://buildroot.org/downloads/manual/manual.html#customize-packages For instance, here is the package used in the minikube.iso (that only uses podman to load images into cri-o storage): https://github.com/kubernetes/minikube/tree/master/deploy/iso/minikube-iso/package/podman |
Ah, I see what you mean @afbjorklund, thanks! And in that case, I think we can close this issue. |
Most likely, any such packaging of podman would also have to include all the dependencies?
And the best is to use the language-specific make fragments (Go, Rust, etc) where possible:
|
User : Manthan Gajera