Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated openblas from validate to validate_build #24038

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

queltosh
Copy link

Specify library name and version: openblas/*

fixes #24037

Validation method fails on cross compilation environment despite native packages are in repo. Apparently is because validate is run always, and this validations should be run only on build stage. Renaming the method name to validate_build looks better approach.


Validation method fails on cross compilation environment despite  native packages are in repo. 
Apparently is because validate is run always, and this validations should be run only on build stage.
Renaming the method name to validate_build looks better approach.
@CLAassistant
Copy link

CLAassistant commented May 20, 2024

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

1 similar comment
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Sorry, the build is only launched for Access Request users. You can request access writing in this issue.

Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

See details:

Sorry, the build is only launched for Access Request users. You can request access writing in this issue.

@ericLemanissierBot
Copy link

I detected other pull requests that are modifying openblas/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@@ -68,7 +68,7 @@ def configure(self):
if self.options.shared:
self.options.rm_safe("fPIC")

def validate(self):
def validate_build(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say it is likely that the only condition that needs to be moved to validate_build() is the one:

raise ConanInvalidConfiguration("Cross-building not implemented")

All the other condition seem good as validate(), those are not about cross-building but they are also meant for consumption of the package, irrespective of the build, so those are good in validate()

@jcar87 jcar87 self-assigned this May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[package] openblas/*: Native package not working in cross compilation environment
6 participants