-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated openblas from validate to validate_build #24038
base: master
Are you sure you want to change the base?
Conversation
Validation method fails on cross compilation environment despite native packages are in repo. Apparently is because validate is run always, and this validations should be run only on build stage. Renaming the method name to validate_build looks better approach.
This comment has been minimized.
This comment has been minimized.
1 similar comment
Conan v1 pipeline ❌Sorry, the build is only launched for Access Request users. You can request access writing in this issue. Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping See details:Sorry, the build is only launched for Access Request users. You can request access writing in this issue. |
I detected other pull requests that are modifying openblas/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
@@ -68,7 +68,7 @@ def configure(self): | |||
if self.options.shared: | |||
self.options.rm_safe("fPIC") | |||
|
|||
def validate(self): | |||
def validate_build(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say it is likely that the only condition that needs to be moved to validate_build()
is the one:
raise ConanInvalidConfiguration("Cross-building not implemented")
All the other condition seem good as validate()
, those are not about cross-building but they are also meant for consumption of the package, irrespective of the build, so those are good in validate()
Specify library name and version: openblas/*
fixes #24037
Validation method fails on cross compilation environment despite native packages are in repo. Apparently is because validate is run always, and this validations should be run only on build stage. Renaming the method name to validate_build looks better approach.