-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hermes: add recipe #24010
base: master
Are you sure you want to change the base?
hermes: add recipe #24010
Conversation
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 86bbb44hermes/0.12.0@#7a1bd4a27244a625b64fbe4bf305cbe9
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Some initial comments :)
recipes/hermes/all/conandata.yml
Outdated
@@ -0,0 +1,9 @@ | |||
sources: | |||
"0.12.0": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonder if they'll ever release a new tagged version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RubenRBS
I missed tagged versions.
I will update it
recipes/hermes/all/conandata.yml
Outdated
sha256: "bd8fd158381813483123eb1ab553ed08db68e4949f314c99ee8fa79fa8f3e7ed" | ||
patches: | ||
"0.12.0": | ||
- patch_file: "patches/0001-include-cstdint.patch" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has this been reported upstream? it's quite common for libraries not to import the necessary headers, but I think they'd appreciate the report :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already fixed in upstream. Thanks!
url = "https://github.com/conan-io/conan-center-index" | ||
homepage = "https://github.com/facebook/hermes" | ||
topics = ("javascript", "ahead-of-time", "react native") | ||
settings = "os", "arch", "compiler", "build_type" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing package_type
:)
cmake_layout(self, src_folder="src") | ||
|
||
def requirements(self): | ||
self.requires("icu/74.2") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like this would require cpython? https://github.com/facebook/hermes/blob/8a272222bdd97435e1c4f2bae9ad207cff8369af/CMakeLists.txt#L81 or am I missing something?
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ❌Failure in build 4 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
@RubenRBS |
Specify library name and version: hermes/*