Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hermes: add recipe #24010

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

hermes: add recipe #24010

wants to merge 4 commits into from

Conversation

toge
Copy link
Contributor

@toge toge commented May 16, 2024

Specify library name and version: hermes/*


@conan-center-bot

This comment has been minimized.

Copy link
Contributor

Hooks produced the following warnings for commit 86bbb44
hermes/0.12.0@#7a1bd4a27244a625b64fbe4bf305cbe9
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './test/ApplePlatformsIntegrationTestApp/ApplePlatformsIntegrationTests.xcodeproj/xcshareddata/xcschemes/ApplePlatformsIntegrationMobileTests.xcscheme' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './test/ApplePlatformsIntegrationTestApp/ApplePlatformsIntegrationTests.xcodeproj/project.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.

@RubenRBS RubenRBS self-assigned this May 16, 2024
Copy link
Member

@RubenRBS RubenRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Some initial comments :)

@@ -0,0 +1,9 @@
sources:
"0.12.0":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder if they'll ever release a new tagged version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RubenRBS
I missed tagged versions.
I will update it

sha256: "bd8fd158381813483123eb1ab553ed08db68e4949f314c99ee8fa79fa8f3e7ed"
patches:
"0.12.0":
- patch_file: "patches/0001-include-cstdint.patch"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this been reported upstream? it's quite common for libraries not to import the necessary headers, but I think they'd appreciate the report :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already fixed in upstream. Thanks!

url = "https://github.com/conan-io/conan-center-index"
homepage = "https://github.com/facebook/hermes"
topics = ("javascript", "ahead-of-time", "react native")
settings = "os", "arch", "compiler", "build_type"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing package_type :)

cmake_layout(self, src_folder="src")

def requirements(self):
self.requires("icu/74.2")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this would require cpython? https://github.com/facebook/hermes/blob/8a272222bdd97435e1c4f2bae9ad207cff8369af/CMakeLists.txt#L81 or am I missing something?

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Failure in build 4 (525e8c5a53993b1136e93dd0d64f3bc3fa90df79):

  • hermes/2024-04-29:
    Do not raise ConanInvalidConfiguration from build() method. Please, move that same check to validate() method.

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@toge
Copy link
Contributor Author

toge commented May 20, 2024

@RubenRBS
It seems to be same issue.
#24011 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants