New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: memory leak #20720

Open

niu2x wants to merge 1 commit into cocos2d:v4 from niu2x:v4

Contributor

niu2x commented Jan 22, 2022

i think CommandBufferGL::setVertexBuffer and CommandBufferGL::setIndexBuffer should do same things.

check weather new value is different from old value.
release old value, retain new value.

there's memory leak in CommandBufferGL::setVertexBuffer if not release old value


          bugfix: memory leak

b801115

we should release old vertex buffer.

Contributor Author

niu2x commented Jan 22, 2022

checks fail due to: /usr/bin/ld: cannot find -lXxf86vm.
it's not my fault...

iLostMyDriversLicense reviewed

View reviewed changes

cocos/renderer/backend/opengl/CommandBufferGL.cpp Show resolved Hide resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment