Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #20608 - Fix compile error on MacOSX big sur #20696

Open
wants to merge 1 commit into
base: v3
Choose a base branch
from

Conversation

Riyaaaaa
Copy link
Contributor

@Riyaaaaa Riyaaaaa commented Nov 26, 2021

Fixed: #20608
Maybe related: #20435

environment

OS: MacOSX 11.3 big sur
Xcode: 13.1
cmake: 3.21.2

description

Compile errors occurred when Xcode project is generated from cmake on MacOSX big sur.

clang: error: no such file or directory: '/usr/lib/libiconv.dylib'

Bacause iconv path is resolved by find_library in CocosConfigDepend.cmake as below.

find_library(ICONV_LIBRARY iconv)

But ICONV_LIBRARY always be set /usr/lib/libconv.dylib ignoring sys_root. /usr/lib seems to be no longer available and it is located at /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk/usr/lib/libiconv.tbd on big sur.

I guess ICONV_LIBRARY is already defined by cmake system so find_library do nothing.
https://cmake.org/cmake/help/latest/module/FindIconv.html

solution

I used other name so that avoid conflicting name.

@Riyaaaaa
Copy link
Contributor Author

I faced this issue when building my project as MacOSX application, but it is also possible to occur on iOS application if you are using cmake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant