test(fix): increase the short timeout #4609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sxd
requested review from
jsilvela,
NiccoloFei,
litaocdl and
a team
as code owners
github-actions
bot
added
backport-requested ◀️
|
❗ By default, the pull request is configured to backport to all release branches.
|
sxd
force-pushed
the
dev/4606
branch
2 times, most recently
from
e117b0b
to
a00aee2
Compare
NiccoloFei
added a commit
to EnterpriseDB/cloudnative-pg
that referenced
this pull request
May 24, 2024
Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com>
sxd
force-pushed
the
dev/4606
branch
2 times, most recently
from
5c6e144
to
87c4f01
Compare
NiccoloFei
approved these changes
May 28, 2024
mnencia
reviewed
May 29, 2024
The short timeout that is only used on tablespaces tests it was by default set to 5 seconds, this is a bit too short and it was producing some failures in some of the cloud environment tests. Closes #4606 Signed-off-by: Jonathan Gonzalez V <jonathan.gonzalez@enterprisedb.com>
Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com>
Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com>
Remove `prometheus`, since it's not an existing filter. Adding `tablespaces`. Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com>
Signed-off-by: Jonathan Gonzalez V <jonathan.gonzalez@enterprisedb.com>
Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com>
Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Signed-off-by: Jonathan Gonzalez V. <jonathan.abdiel@gmail.com> Signed-off-by: Jonathan Gonzalez V <jonathan.gonzalez@enterprisedb.com>
mnencia
approved these changes
May 29, 2024
|
/test |
|
@mnencia, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/9289873857 |
|
/ok-to-merge E2E failures are unrelated. |
cnpg-bot
pushed a commit
that referenced
this pull request
May 30, 2024
The short timeout, which is only used on tablespaces tests, is set to 5 seconds by default. This is too short and produced some failures in some cloud environment tests. Additionally, we stop logging errors that aren't errors at all while getting the pod logs. Closes #4606 Signed-off-by: Jonathan Gonzalez V <jonathan.gonzalez@enterprisedb.com> Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com> Signed-off-by: Jonathan Gonzalez V. <jonathan.abdiel@gmail.com> Co-authored-by: Niccolò Fei <niccolo.fei@enterprisedb.com> Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> (cherry picked from commit 4b454e6)
mnencia
pushed a commit
that referenced
this pull request
May 30, 2024
The short timeout, which is only used on tablespaces tests, is set to 5 seconds by default. This is too short and produced some failures in some cloud environment tests. Additionally, we stop logging errors that aren't errors at all while getting the pod logs. Closes #4606 Signed-off-by: Jonathan Gonzalez V <jonathan.gonzalez@enterprisedb.com> Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com> Signed-off-by: Jonathan Gonzalez V. <jonathan.abdiel@gmail.com> Co-authored-by: Niccolò Fei <niccolo.fei@enterprisedb.com> Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> (cherry picked from commit 4b454e6)
mnencia
pushed a commit
that referenced
this pull request
May 30, 2024
The short timeout, which is only used on tablespaces tests, is set to 5 seconds by default. This is too short and produced some failures in some cloud environment tests. Additionally, we stop logging errors that aren't errors at all while getting the pod logs. Closes #4606 Signed-off-by: Jonathan Gonzalez V <jonathan.gonzalez@enterprisedb.com> Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com> Signed-off-by: Jonathan Gonzalez V. <jonathan.abdiel@gmail.com> Co-authored-by: Niccolò Fei <niccolo.fei@enterprisedb.com> Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> (cherry picked from commit 4b454e6)
dougkirkley
pushed a commit
to dougkirkley/cloudnative-pg
that referenced
this pull request
Jun 11, 2024
The short timeout, which is only used on tablespaces tests, is set to 5 seconds by default. This is too short and produced some failures in some cloud environment tests. Additionally, we stop logging errors that aren't errors at all while getting the pod logs. Closes cloudnative-pg#4606 Signed-off-by: Jonathan Gonzalez V <jonathan.gonzalez@enterprisedb.com> Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com> Signed-off-by: Jonathan Gonzalez V. <jonathan.abdiel@gmail.com> Co-authored-by: Niccolò Fei <niccolo.fei@enterprisedb.com> Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Signed-off-by: Douglass Kirkley <dkirkley@eitccorp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The short timeout that is only used on tablespaces tests it was by default set to
5 seconds, this is a bit too short and it was producing some failures in some of
the cloud environment tests.
Also, we stop logging errors that aren't errors at all while getting the pod logs.
Closes #4606