Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow raising replication parameters when restoring a backup #4564

Merged
merged 6 commits into from
Jun 3, 2024
Merged

fix: allow raising replication parameters when restoring a backup #4564

merged 6 commits into from
Jun 3, 2024

Conversation

litaocdl
Copy link
Collaborator

@litaocdl litaocdl commented May 17, 2024 •
edited by leonardoce

Ensure the PostgreSQL replication parameters are set to the higher value between
the ones specified in the cluster specification and the ones stored in the backup.

This will ensure that the backup will be restored correctly while allowing the users
to raise their value to accommodate changes in the configuration that have
happened after the backup was taken.

Partially closes #2478 #2337

@litaocdl litaocdl requested a review from a team as a code owner May 17, 2024 11:13
@github-actions github-actions bot added backport-requested ◀️ This pull request should be backported to all supported releases release-1.21 release-1.22 release-1.23 labels May 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

❗ By default, the pull request is configured to backport to all release branches.

  • To stop backporting this pr, remove the label: backport-requested ◀️ or add the label 'do not backport'
  • To stop backporting this pr to a certain release branch, remove the specific branch label: release-x.y

@litaocdl
Copy link
Collaborator Author

e2e is running here https://github.com/EnterpriseDB/cloudnative-pg/actions/runs/9136158988

@litaocdl litaocdl changed the title fix: use proper sensitive parameters value in restore job fix: use proper value for enforced parameters in restore job May 18, 2024
@mnencia
Copy link
Member

mnencia commented May 22, 2024

/test tl=4

@github-actions GitHub Actions
Copy link
Contributor

@mnencia, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/9189522123

@mnencia mnencia force-pushed the dev/2478 branch 5 times, most recently from 72f88cb to 8f05ae4 Compare May 24, 2024 16:38
@mnencia
Copy link
Member

mnencia commented May 27, 2024

E2E test running on the fork https://github.com/EnterpriseDB/cloudnative-pg/actions/runs/9251317637

@mnencia mnencia force-pushed the dev/2478 branch 4 times, most recently from fded2b4 to 55a601a Compare May 27, 2024 12:12
@leonardoce
Copy link
Contributor

https://github.com/EnterpriseDB/cloudnative-pg/actions/runs/9315905824

@leonardoce leonardoce force-pushed the dev/2478 branch 2 times, most recently from 1d4acfc to e45130f Compare June 3, 2024 07:45
@leonardoce
Copy link
Contributor

/ok-to-merge e2e tests are fine

@cnpg-bot cnpg-bot added the ok to merge 👌 This PR can be merged label Jun 3, 2024
@leonardoce leonardoce changed the title fix: use proper value for enforced parameters in restore job fix: allow user to raise replication parameters while restoring a backup Jun 3, 2024
@leonardoce leonardoce changed the title fix: allow user to raise replication parameters while restoring a backup fix: allow user to raise replication parameters when restoring a backup Jun 3, 2024
@leonardoce leonardoce changed the title fix: allow user to raise replication parameters when restoring a backup fix: allow raising replication parameters when restoring a backup Jun 3, 2024
litaocdl and others added 6 commits June 3, 2024 10:23
@litaocdl @leonardoce
fix: use proper sensitive parameters value in restore job
bef71bf 
Signed-off-by: Tao Li <tao.li@enterprisedb.com>
@mnencia @leonardoce
review: clarify the flow
b40e3e1 
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
@litaocdl @leonardoce
update comments
88aa15e 
Signed-off-by: Tao Li <tao.li@enterprisedb.com>
@litaocdl @leonardoce
Leonardo's comments
6e04b0e 
Co-authored-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
Signed-off-by: Tao Li <tao.li@enterprisedb.com>
@litaocdl @leonardoce
commit based on comments
3ac3705 
Signed-off-by: Tao Li <tao.li@enterprisedb.com>
@leonardoce
chore: clarify comments
da31f4b 
Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
@leonardoce leonardoce merged commit 87f80ce into main Jun 3, 2024
20 checks passed
@leonardoce leonardoce deleted the dev/2478 branch June 3, 2024 08:24
cnpg-bot pushed a commit that referenced this pull request Jun 3, 2024
@litaocdl
fix: allow raising replication parameters when restoring a backup (#4564
2d1fdab 
)

Ensure the PostgreSQL replication parameters are set to the higher value
between the ones specified in the cluster specification and the ones
stored in the backup.

This will ensure that the backup will be restored correctly while
allowing the users to raise their value to accommodate changes in the
configuration that have happened after the backup was taken.

Partially closes #2478 #2337

Signed-off-by: Tao Li <tao.li@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Co-authored-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
(cherry picked from commit 87f80ce)
cnpg-bot pushed a commit that referenced this pull request Jun 3, 2024
@litaocdl
fix: allow raising replication parameters when restoring a backup (#4564
20bf550 
)

Ensure the PostgreSQL replication parameters are set to the higher value
between the ones specified in the cluster specification and the ones
stored in the backup.

This will ensure that the backup will be restored correctly while
allowing the users to raise their value to accommodate changes in the
configuration that have happened after the backup was taken.

Partially closes #2478 #2337

Signed-off-by: Tao Li <tao.li@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Co-authored-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
(cherry picked from commit 87f80ce)
cnpg-bot pushed a commit that referenced this pull request Jun 3, 2024
@litaocdl
fix: allow raising replication parameters when restoring a backup (#4564
fa001cb 
)

Ensure the PostgreSQL replication parameters are set to the higher value
between the ones specified in the cluster specification and the ones
stored in the backup.

This will ensure that the backup will be restored correctly while
allowing the users to raise their value to accommodate changes in the
configuration that have happened after the backup was taken.

Partially closes #2478 #2337

Signed-off-by: Tao Li <tao.li@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Co-authored-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
(cherry picked from commit 87f80ce)
dougkirkley pushed a commit to dougkirkley/cloudnative-pg that referenced this pull request Jun 11, 2024
@litaocdl @mnencia @leonardoce
fix: allow raising replication parameters when restoring a backup (cl…
c35b15e 
…oudnative-pg#4564)

Ensure the PostgreSQL replication parameters are set to the higher value
between the ones specified in the cluster specification and the ones
stored in the backup.

This will ensure that the backup will be restored correctly while
allowing the users to raise their value to accommodate changes in the
configuration that have happened after the backup was taken.

Partially closes cloudnative-pg#2478 cloudnative-pg#2337

Signed-off-by: Tao Li <tao.li@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Co-authored-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
Signed-off-by: Douglass Kirkley <dkirkley@eitccorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnencia mnencia mnencia approved these changes

@leonardoce leonardoce leonardoce approved these changes

@YanniHu1996 YanniHu1996 YanniHu1996 approved these changes

Assignees
No one assigned
Labels
backport-requested ◀️ This pull request should be backported to all supported releases ok to merge 👌 This PR can be merged release-1.21 release-1.22 release-1.23
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recovery failure with barman due to max_connections
5 participants
@litaocdl @mnencia @leonardoce @YanniHu1996 @cnpg-bot