feat: allow injecting schema into lifecycle hook #4402
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com>
github-actions
bot
added
backport-requested ◀️
|
❗ By default, the pull request is configured to backport to all release branches.
|
phisco
commented
Apr 29, 2024
| // Skip unknown object | ||
| return nil, nil | ||
| return object, nil |
There was a problem hiding this comment.
this is already covered by #4282, I do think it's the right thing to do.
phisco
commented
Apr 29, 2024
| @@ -144,7 +145,7 @@ func (data *data) LifecycleHook( | |||
| return object, nil | |||
| } | |||
|
|
|||
| decoder := scheme.Codecs.UniversalDeserializer() | |||
| decoder := serializer.NewCodecFactory(scheme.Scheme).UniversalDeserializer() | |||
There was a problem hiding this comment.
would be better to move this to a builder and only create it once.
phisco
commented
Apr 29, 2024
| ctx context.Context, | ||
| operationType plugin.OperationVerb, | ||
| schema *runtime.Scheme, |
There was a problem hiding this comment.
I feel it could be passed through a builder or something instead of adding one more parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt at fixing the root cause of #4286, mostly a POC, I feel it could be improved.