Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow additionalCommandArgs to be passed to barman-cloud-wal-archive #4360

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

pselliotc
Copy link

@pselliotc pselliotc commented Apr 24, 2024

Closes #4357

Adds the additionalCommandArgs property to WalBackupConfiguration, allowing command line args to be passed to barman-cloud-wal-archive.

@github-actions github-actions bot added backport-requested ◀️ This pull request should be backported to all supported releases release-1.21 release-1.22 labels Apr 24, 2024
Copy link
Contributor

❗ By default, the pull request is configured to backport to all release branches.

  • To stop backporting this pr, remove the label: backport-requested ◀️ or add the label 'do not backport'
  • To stop backporting this pr to a certain release branch, remove the specific branch label: release-x.y

@mnencia
Copy link
Member

mnencia commented May 30, 2024

Hi @pselliotc, thanks for the contribution. Could you please update docs/src/backup_barmanobjectstore.md to include the new parameter?

@gabriele-wolfox
Copy link
Contributor

gabriele-wolfox commented Jun 4, 2024

/test feature_type=backup-restore test_level=4

Looks like I am not able to run e2e in this branch.
I would like to run the backup/restore ones, in order to see if there are any regressions.

@leonardoce
Copy link
Contributor

/test feature_type=backup-restore test_level=4

Copy link
Contributor

github-actions bot commented Jun 4, 2024

@leonardoce, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/9367407602

…chive

Signed-off-by: Elliot <elliot.charlton@portswigger.net>
Signed-off-by: Elliot <elliot.charlton@portswigger.net>
Signed-off-by: Elliot <elliot.charlton@portswigger.net>
Signed-off-by: Elliot <elliot.charlton@portswigger.net>
Signed-off-by: Elliot <elliot.charlton@portswigger.net>
Signed-off-by: Elliot <elliot.charlton@portswigger.net>
Signed-off-by: Elliot <elliot.charlton@portswigger.net>
Signed-off-by: Elliot <elliot.charlton@portswigger.net>
@litaocdl
Copy link
Collaborator

/test limit=local

Copy link
Contributor

@litaocdl, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/9461358335

@github-actions github-actions bot added the ok to merge 👌 This PR can be merged label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-requested ◀️ This pull request should be backported to all supported releases ok to merge 👌 This PR can be merged release-1.21 release-1.22
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Expose additional command args for barman-cloud-wal-archive
5 participants