-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add metrics for pg_stat_checkpointer in v17+ #4341
Conversation
❗ By default, the pull request is configured to backport to all release branches.
|
IMHO, this patch should have first fixed the issue for 17 then added pg_stat_checkpointer. |
Because the query mapping needs to be unique (even though the 2 queries are mutually exclusive), I've distinguished the bgwriter metric's name in the following way:
I've also thought about including and serving the 4 remaining bgwriter columns directly from the Tests running on: https://github.com/cloudnative-pg/postgres-trunk-containers/actions/runs/8881859306 |
/test depth=push limit=local test_level=4 feature_type=observability |
@sxd, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/8939199640 |
Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com>
I don't like the idea to generate metrics with different names from the same table, although on different postgres version. Additionally, such changes should affect the grafana dashboard as well. |
Superseded by #4779 |
❗ By default, the pull request is configured to backport to all release branches.
|
Closes #3411