Decouple k8s client heartbeat from connection timeout and keep alive #32625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
dlapcevic
force-pushed
the
k8s-heatbeat-timeout
branch
from
565021c
to
2fe1a90
Compare
dlapcevic
force-pushed
the
k8s-heatbeat-timeout
branch
2 times, most recently
from
1fa8c07
to
e8a4483
Compare
|
/test |
The main reason to introduce this is to be able to increase the heartbeat interval without affecting the k8s client connection settings. It also allows the possibility to disable heartbeat, by setting `k8s-heartbeat-timeout` to 0, without disable the k8s client itself. ```release-note When upgrading, users can experience a change to their configuration if they were overriding the `k8s-heartbeat-timeout` flag. k8s client timeout and keep alive are no longer getting values from the `k8s-heartbeat-timeout` flag, but rather would have default values (30 seconds). ``` Signed-off-by: Dorde Lapcevic <dordel@google.com>
dlapcevic
force-pushed
the
k8s-heatbeat-timeout
branch
from
e8a4483
to
7342a1d
Compare
|
/test |
|
thanks for the improvements @dlapcevic ... one more thing, can we put the auto generated Documentation changes into a seperate commit? Makes reading through commits a lot easier 😄 |
asauber
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main reason to introduce this is to be able to increase the heartbeat interval without affecting the k8s client connection settings.
It also allows the possibility to disable heartbeat, by setting
k8s-heartbeat-timeoutto 0, without disable the k8s client itself.Signed-off-by: Dorde Lapcevic <dordel@google.com>