Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNI: Update skel.PluginMain to skel.PluginMainFunc for cni 1.2.0 #32618

Closed
wants to merge 1 commit into from

Conversation

scydas
Copy link

@scydas scydas commented May 19, 2024

@scydas scydas requested a review from a team as a code owner May 19, 2024 15:36
@scydas scydas requested a review from tommyp1ckles May 19, 2024 15:36
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 19, 2024
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label May 19, 2024
@tommyp1ckles
Copy link
Contributor

hi @scydas. Thanks for the PR 😄

Could you fill provide more context/information regarding these changes in the PR description as well as the commit message as described here.

@scydas scydas changed the title update cni to 1.2.0 CNI: Update skel.PluginMain to skel.PluginMainFunc for cni 1.2.0 May 20, 2024
@tommyp1ckles tommyp1ckles requested a review from squeed May 22, 2024 01:00
Copy link
Contributor

@tommyp1ckles tommyp1ckles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, @squeed mind taking a quick look as well?

@squeed
Copy link
Contributor

squeed commented May 27, 2024

/test

@maintainer-s-little-helper
Copy link

Commit dd01ba7 does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label May 30, 2024
@maintainer-s-little-helper
Copy link

Commits dd01ba7, 7b5af3b do not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label May 31, 2024
@scydas scydas closed this by deleting the head repository May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. kind/community-contribution This was a contribution made by a community member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants