Re-use existing .refitter file if it already exists #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christianhelle
added
enhancement
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Classification
This pull request ensures that the existing .refitter file is not overwritten when the user runs the refitter command. It also updates the serialization method to use
System.Text.Json.JsonSerializerinstead ofJsonConvert.SerializeObject.PR Summary
The pull request modifies the
RefitterCodeGenerator.csfile to improve the handling ofRefitGeneratorSettingsand updates the serialization method.RefitterCodeGenerator.cs: Updatedusingdirectives, added logic to check for a.refitterfile before deserializing settings, and moved the serialization of settings to an else block.RefitterCodeGenerator.cs: Switched fromJsonConvert.SerializeObjectto a newSerializemethod for creating theDependencyContext.RefitterCodeGenerator.cs: Added a new privateSerializemethod for serializingRefitGeneratorSettingswithSystem.Text.Json.JsonSerializer.