fix(helm): should not set webhook caBundle when cert-manager enabled #4395
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
We use FluxCD to install chaos-mesh, and prefer to use cert-manager for all PKI-related in our clusters. When enabling cert-manager in chaos-mesh Helm chart, the templates for the validating and mutating webhook set a dummy value for the webhook
caBundle
field. This is not correct IMO, and causes Flux and cert-manager to "fight" about managing the field - since both are reconciling the resources periodically.What's changed and how it works?
This PR removes the dummy value set for webhook
caBundle
field when cert-manager enabled, which will allow cert-manager (ca-injector) to fully manage this particular field in the resources.Related changes
UI interface
Cherry-pick to release branches (optional)
Checklist
CHANGELOG
CHANGELOG.md
Tests
Side effects
DCO
If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it: