-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MenuOptionGroup
virtualized (for large lists)
#8087
MenuOptionGroup
virtualized (for large lists)
#8087
Conversation
🦋 Changeset detectedLatest commit: 3981493 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
MenuOptionGroup
virtualized (for large lists)
@@ -46,7 +46,8 @@ | |||
"@chakra-ui/react-use-controllable-state": "workspace:*", | |||
"@chakra-ui/react-use-outside-click": "workspace:*", | |||
"@chakra-ui/react-use-update-effect": "workspace:*", | |||
"@chakra-ui/shared-utils": "workspace:*" | |||
"@chakra-ui/shared-utils": "workspace:*", | |||
"@tanstack/react-virtual": "3.0.0-beta.65" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we specify a looser version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is not https://github.com/TanStack/virtual/tags
Thanks for working on this @baptooo. I appreciate the patience as well We don't intend to support virtualization out of the box. I would recommend handling this in your userland code. Thanks for understanding. |
Closes #7852
📝 Description
⛳️ Current behavior (updates)
🚀 New behavior
See it live on storybook
💣 Is this a breaking change (Yes/No):
No as these parameters are fully optional and not setting them will result into having the current behavior.
📝 Additional Information
Add of a dedicated story called
PerformanceOptionGroup
underComponents / Overlay / Menu
in Storybook.