squid: librbd: don't crash on a zero-length read if buffer is NULL #57571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While at it, don't assign ret unnecessarily. Signed-off-by: Ilya Dryomov <idryomov@gmail.com> (cherry picked from commit c50a96c)
Currently only data is checked, based on the size of the file. Check that the size of the image matches that. Signed-off-by: Ilya Dryomov <idryomov@gmail.com> (cherry picked from commit 47ad28f)
While legal, it's specified as implementation-defined behavior and newer valgrind throws InvalidSize error on it. Fixes: https://tracker.ceph.com/issues/65813 Signed-off-by: Ilya Dryomov <idryomov@gmail.com> (cherry picked from commit 1484480)
The previous commit uncovered an old bug, introduced in commit 9867804 ("Striper: Add function 'assemble_result(CephContext *cct, char *buffer, size_t len)' in StripedReadResult."). The buffer is allowed to be NULL when assemble_result() is called -- it becomes a problem only if some data was read. Strengthen ZeroLengthRead and ZeroLengthWrite tests to cover both a bogus pointer and a NULL pointer for buffer. Signed-off-by: Ilya Dryomov <idryomov@gmail.com> (cherry picked from commit e6773a9)
|
jenkins test windows |
ajarr
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/66114
backport of #57433
parent tracker: https://tracker.ceph.com/issues/65813