Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document --no-sandbox Linux launch option #49

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Document --no-sandbox Linux launch option #49

wants to merge 1 commit into from

Conversation

dfabulich
Copy link
Contributor

Fixes #42.

@dfabulich
Copy link
Contributor Author

I can't say that I entirely understand why this workaround fixes #42, but it does.

One of our users first pointed out that --disable-seccomp-filter-sandbox helped to mitigate the problem; the app was still sometimes crashing/hanging, but much less frequently. I reviewed https://chromium.googlesource.com/chromium/src/+/0e94f26e8/docs/linux_sandboxing.md and figured that I'd give --no-sandbox a try, and, sure enough, it worked great.

@dfabulich
Copy link
Contributor Author

This documentation PR has been open for months now. Can we merge this?

ceifa
ceifa reviewed May 7, 2023
View reviewed changes
README.md
@@ -68,6 +68,10 @@ To make the steam overlay working, call the `electronEnableSteamOverlay` on the
require('steamworks.js').electronEnableSteamOverlay()
```

[Some users have reported an issue when launching Linux apps](https://github.com/ceifa/steamworks.js/issues/42). A workaround is available, to pass a `--no-sandbox` as an argument to the app launcher in Steamworks --> Steamworks Settings --> Installation --> General Installation --> Launch Options. (Note that `--no-sandbox` makes it unsafe to run third-party code, but as long as you're only running game code under your own control, it should be fine.) A screenshot example of this appears below.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only happens on steam deck or linux in general?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Back in Sep 2022, I reproduced the issue on Ubuntu 22 and Manjaro 22.

@ceifa
Copy link
Owner

ceifa commented Aug 2, 2023

Can we make the screenshot an external link? For something that doesn't need to be configured on all cases, it's taking up a lot of documentation space

@dfabulich
Copy link
Contributor Author

dfabulich commented Aug 2, 2023 •
edited

It needs to be configured on all cases. Most people just don't realize it (or they don't support Linux/Steam Deck).

@ceifa
Copy link
Owner

ceifa commented Aug 29, 2023

It needs to be configured on all cases. Most people just don't realize it (or they don't support Linux/Steam Deck).

My steam game runs without it and works great on ubuntu

@dfabulich
Copy link
Contributor Author

What's your game? Does it work on Steam Deck?

@ceifa
Copy link
Owner

ceifa commented Sep 2, 2023

Does it work on Steam Deck?

No, and it's not intended to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ceifa ceifa ceifa left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error running app on Steam Deck
2 participants
@dfabulich @ceifa