-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev: Update radar data #6313
Dev: Update radar data #6313
Conversation
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
V.Y *= TO_METERS; | ||
|
||
|
||
// Для дебага! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you remove comments in other languages than English?
|
||
|
||
// Для дебага! | ||
//UE_LOG(LogTemp, Warning, TEXT("Vf: %s"), *DV.ToString()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you delete commented code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed it
Hello! Could you resolve Radar.cpp conflicts and comments? |
Comments in another language and commented code have been removed
There are two conflicts there still |
I think I fixed the conflicts, but I clicked the merge button without thinking. Do I understand correctly that nothing critical happened, and my changes were saved in the repository? |
Your changes are there still, could you update the backlog and then the PR would be ready to go in |
Did I understand correctly that I need to make a description of my changes to the file CHANGELOG.md ? If so, how to arrange it correctly? Just add a line to the list of recent updates? |
Yeah, that's it add a line commenting this. Many people will read and maybe this will be affecting their code |
Hello, We have been looking at your PR. We want to keep the previous version of velocity. You could add your velocity y and x on top of that. For now we are not merging your PR |
Description
The speed data that is transmitted from the radars has been updated. In the current version, one speed component was issued, which was calculated as the scalar product of the relative velocity vector of the hitted actor and the direction vector per actor. In the new version, the speed is divided into components along the axes Ox and Oy of the radar. The speed is considered relative to the radar.
Where has this been tested?
Possible Drawbacks
Carla may no longer be supported by the current version of ros-bridge.
This change is