feat: org-wide workflows

[CarinaWolli]

What does this PR do?

• Org-workflow can be set active on teams and will trigger for all the team event types + all the user event types of the team members.
  • if a user is member of several active teams, the workflow only triggers once
• Add 'apply to all, including future teams/event-types'
• workflows/update.handler is refactored into smaller functions that can be reused and tested.
• Also fixes some small existing bugs that I found when refactoring the code

Todo:

• When member is removed from team and workflow has 'active on all, including future' set then reminders aren't deleted (reminders should be deleted if user isn't member of any other team)

Fixes #14638
Fixes CAL-3489

Mandatory Tasks (DO NOT REMOVE)

• I have self-reviewed the code (A decent size PR without self-review might be rejected)
• I have added a Docs issue here if this PR makes changes that would require a documentation change --> Created an issue for that: Org-wide workflows docs#93
• I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

How should this be tested?

Basic test:

• Create an org workflow
• Set active on a team (or all teams)
• Book a team event type --> see if workflow triggers
• Book a user event type of a team member --> see if workflow triggers

Test other cases, for example:

• test with several teams when some team members are part of several teams --> a workflow should always just trigger once
• Test updating a 'before event' workflow and see if WorkflowReminders are correctly adjusted
• Test removing team workflow and see if reminders are deleted (if user is still part of another team that is active, the reminder should stay)
• delete/add reminders for deleted/added steps
• Add reminders for new active teams
• Test if 'active on all teams/even-types, including future ones' works with new event types/teams

[graphite-app]

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (06/11/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (06/11/24)

1 reviewer was added to this PR based on Keith Williams's automation.

[hariombalhara]

Workflow count is wrong on the left. This is the case for Acme's owner's event

Also, the Org workflow toggle isn't in its disabled state visually

[hariombalhara]

I think to clearly communicate the meaning, we should change the message to Active on all teams and their members

Initially I thought it could be just the team events but it is those team's members' events as well.

[hariombalhara]

Getting my head around workflows right now. So, submitting partial review

[hariombalhara]

Getting my head around workflows right now. So, submitting partial review

[hariombalhara]

Have we handled the cleanup of workflows when a user is removed from a team. In my testing I found that the reminder remains even when there is no team.

No Team is there. The user was a member of a team earlier

But workflow that came from Org is still there

[CarinaWolli]

Have we handled the cleanup of workflows when a user is removed from a team. In my testing I found that the reminder remains even when there is no team.

Should be handled here: https://github.com/calcom/cal.com/pull/15083/files#diff-00296740ffe644796cf7e681b96fe07cd4fa0283d1cef7ef345635f789a34cc9L1

do you have 'active on all including future teams' enabled? I think in that case it currently doesn't remove the reminder, which it should tho (https://github.com/calcom/cal.com/pull/15083/files#diff-00296740ffe644796cf7e681b96fe07cd4fa0283d1cef7ef345635f789a34cc9R160)

[CarinaWolli]

I think to clearly communicate the meaning, we should change the message to Active on all teams and their members

Initially I thought it could be just the team events but it is those team's members' events as well.

What do you think about adding that information here?

[hariombalhara]

Have we handled the cleanup of workflows when a user is removed from a team. In my testing I found that the reminder remains even when there is no team.

Should be handled here: https://github.com/calcom/cal.com/pull/15083/files#diff-00296740ffe644796cf7e681b96fe07cd4fa0283d1cef7ef345635f789a34cc9L1

do you have 'active on all including future teams' enabled? I think in that case it currently doesn't remove the reminder, which it should tho (https://github.com/calcom/cal.com/pull/15083/files#diff-00296740ffe644796cf7e681b96fe07cd4fa0283d1cef7ef345635f789a34cc9R160)

Yeah that was the case exactly

[hariombalhara]

I think to clearly communicate the meaning, we should change the message to Active on all teams and their members

Initially I thought it could be just the team events but it is those team's members' events as well.

What do you think about adding that information here?

Yeah sounds good to me.

[CarinaWolli]

Workflow count is wrong on the left.

I fixed the workflow count: 303798e