Fix NaN due to division by zero #4441
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix NaN due to division by zero
|
Hello @erwincoumans ! Would you kindly review this PR? If there are any concerns or comments, I would greatly appreciate your input and am happy to address them. Thank you very much for your time and consideration! |
|
I would also appreciate clarification on this, as I also ran into this NaN when trying to use a fixed point type for btScalar, and I'm not certain what the proper behavior is supposed to be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered NaN when simulating with a kinematic rigid body, one dynamic rigid body, and one rope anchored between them.
It was solved by avoiding division-by-zero when computing
solverConstraint.m_jacDiagABInv.