Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compatibility with Gym 0.26.0 #4335

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

markub3327
Copy link

Hi @erwincoumans,

for fixing the issues #4331 and openai/gym#3073, I must add order_enforce=False flag to all register() at init.py becouse new version of Gym doesn't allow call env.render() before calling env.reset().

Thanks for your time.

@markub3327
Copy link
Author

For compatibility with Gym 0.26.0 is needed to change the:
if id in registry.env_specs:
To:
if id in registry.keys():

Thanks.

@markub3327 markub3327 changed the title order_enforce=False option in register pybullet_envs compatibility with Gym 0.26.0 Sep 13, 2022
@markub3327
Copy link
Author

For compatibility with Gym 0.26.0 and newer, I must change all step() and reset(), too.

The new form of step() is:

observation, reward, terminated, truncated, info = env.step(action)

The new form of reset() is:

observation, info = env.reset()

The render or renders argument in __init__() in all envs is changed to render_mode.

@erwincoumans Please can you do tests of the correctness?

@erwincoumans
Copy link
Member

erwincoumans commented Sep 25, 2022

Thanks for the pull request. Would this change also make PyBullet incompatible with all older versions of Gym? Is there some gym version check possible? Or remove the order enforcing wrapper after make externally?

@markub3327
Copy link
Author

There are more changes than the wrapper, because Gym 0.26.0 use new form of env.reset() and env.step().

It will be incompatible with the older Gym..... But checking the Gym version can solve this problem.

Thanks.

@anht-nguyen
Copy link

When will these changes for compatibility with Gym 0.26 be merged to the master branch? Thanks!

@araffin
Copy link
Contributor

araffin commented Nov 8, 2023

Fyi, I pushed and released on pypi a subset of pybullet envs compatible with gymnasium: https://github.com/araffin/pybullet_envs_gymnasium
pip install pybullet_envs_gymnasium (I will crosspost this message as it may interest several people)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants