-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reporters/github: Add regex for report notifications only for allowed… #6601
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Basic idea makes sense, I've added some comments for improvements.
Also, a unit test is needed to ensure that the regex filtering works. You can see how TestGitHubCommentPush
reuses TestGitHubStatusPush
to create custom reporter class (in this case we just need custom reporter argument).
4a55c0e
to
59f4c0b
Compare
Looks good. We now need tests, documentation update and a release note. |
6fcca76
to
b245a6f
Compare
… repository reporters/gitlab and reporters/github are conflicting if both are using sourcestamps repository settings. this is making gitlab MR try to report to github. for filtering such behaviour I have enabled a github baseREGEX option on the github reporter that is allowing only notifications towards allowed sourcestamps repository. Signed-off-by: Alice Ferrazzi <alice.ferrazzi@miraclelinux.com>
b245a6f
to
9ce82e1
Compare
Signed-off-by: Alice Ferrazzi <alice.ferrazzi@miraclelinux.com>
eaeefa8
to
fc33f52
Compare
@p12tic added documentation |
2cbf0c3
to
43fe504
Compare
Adding test for testing the option base_re Signed-off-by: Alice Ferrazzi <alice.ferrazzi@miraclelinux.com>
43fe504
to
d360839
Compare
sorry I couldn't work out how to add the tests about this PR, could you help out? |
reporters/gitlab and reporters/github are conflicting if both are using
sourcestamps repository settings. this is making gitlab MR try to report
to github. for filtering such behaviour I have enabled a github
baseREGEX option on the github reporter that is allowing only
notifications towards allowed sourcestamps repository.
Signed-off-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com