Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-5938] Prevent vault coruption on key-rotation on desycned vault #9235

Merged
merged 3 commits into from
May 30, 2024

Conversation

quexten
Copy link
Contributor

@quexten quexten commented May 17, 2024

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Adds client side guardrails on key rotation to prevent corrupting the vault when

  • Sync requests timed out/failed
  • Local cipher decryption failed

Reproduction steps for the corruption this prevents are here: #7709
Server side check for ciphers here: bitwarden/server#4098

Code changes

  • file.ext: Description of what was changed and why

Screenshots

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@quexten quexten requested a review from a team as a code owner May 17, 2024 13:14
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label May 17, 2024
Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 28.09%. Comparing base (ee690cd) to head (292d516).
Report is 6 commits behind head on main.

Files Patch % Lines
...app/auth/key-rotation/user-key-rotation.service.ts 50.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9235   +/-   ##
=======================================
  Coverage   28.08%   28.09%           
=======================================
  Files        2435     2435           
  Lines       70502    70530   +28     
  Branches    13135    13145   +10     
=======================================
+ Hits        19804    19812    +8     
- Misses      49159    49178   +19     
- Partials     1539     1540    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented May 17, 2024

Logo
Checkmarx One – Scan Summary & Details6ae513b5-7a9d-4972-8173-b60d7daa5b1e

No New Or Fixed Issues Found

@jlf0dev jlf0dev requested review from jlf0dev and removed request for ike-kottlowski May 17, 2024 15:24
@quexten quexten removed the needs-qa Marks a PR as requiring QA approval label May 30, 2024
@quexten quexten merged commit 6d0ef65 into main May 30, 2024
34 of 35 checks passed
@quexten quexten deleted the auth/pm-5938/prevent-vault-coruption-on-desycned-vault branch May 30, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants