[PM-7611] Create a new vault settings component [UI changes] #9220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Copy existing vault-settings component - Make new component standalone - Replace app-header with popup-header - Replace nav-buttons with bit-item - Register route to show new component when extension refresh flag is enabled
…s/pm-7611/create-a-new-vault-settings-component-UI-changes
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9220 +/- ##
==========================================
- Coverage 28.14% 28.13% -0.02%
==========================================
Files 2361 2362 +1
Lines 69846 69880 +34
Branches 13133 13139 +6
==========================================
Hits 19660 19660
- Misses 48629 48663 +34
Partials 1557 1557 ☔ View full report in Codecov by Sentry. |
|
New Issues
|
apps/browser/src/vault/popup/settings/vault-settings-v2.component.ts
Outdated
Show resolved
Hide resolved
…s/pm-7611/create-a-new-vault-settings-component-UI-changes
Jingo88
approved these changes
May 17, 2024
…s/pm-7611/create-a-new-vault-settings-component-UI-changes
…s/pm-7611/create-a-new-vault-settings-component-UI-changes
djsmith85
deleted the
tools/pm-7611/create-a-new-vault-settings-component-UI-changes
branch
quexten
pushed a commit
that referenced
this pull request
May 22, 2024
* Create vault-settings-v2 component - Copy existing vault-settings component - Make new component standalone - Replace app-header with popup-header - Replace nav-buttons with bit-item - Register route to show new component when extension refresh flag is enabled * Move sync functionality to vault-settings-v2 * Use anchors instead of buttons when navigating to a sub-page * Removed unneeded component within routing * Use new ToastService instead of PlatformUtils * Remove unused MessagingService --------- Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
With #8840 the navigational changes were made. This is meant to update UI for the extensions refresh according to the new design.
The currently missing trash anchor and page will be added with PM-8125
Code changes
sync.componentwill need to be deleted when we fully switch over to the new designScreenshots
Before
After
Before you submit