Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CL-289] fix text decoration in CL button and item-content #9219

Merged
merged 1 commit into from
May 23, 2024

Conversation

willmartian
Copy link
Contributor

@willmartian willmartian commented May 16, 2024

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

The button and item-content components should not have text decoration when used with an anchor element. This was missed due to certain global styles being present in the web app but not the extension.

Code changes

  • file.ext: Description of what was changed and why

Screenshots

Before:
Screenshot 2024-05-16 at 2 25 44 PM

After:

Screen.Recording.2024-05-16.at.2.26.16.PM.mov

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@willmartian willmartian requested a review from a team as a code owner May 16, 2024 18:30
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label May 16, 2024
@willmartian willmartian removed the needs-qa Marks a PR as requiring QA approval label May 16, 2024
Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.12%. Comparing base (121494f) to head (105b25e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9219   +/-   ##
=======================================
  Coverage   28.12%   28.12%           
=======================================
  Files        2436     2436           
  Lines       70494    70494           
  Branches    13136    13136           
=======================================
  Hits        19829    19829           
  Misses      49130    49130           
  Partials     1535     1535           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details1db140fe-4dcd-483f-bda3-828ab0b63c14

No New Or Fixed Issues Found

@willmartian willmartian merged commit 4b3e63f into main May 23, 2024
65 of 67 checks passed
@willmartian willmartian deleted the ps/CL-289/fix-text-decoration-in-extension branch May 23, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants