Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-7239] Create import-browser-v2 component #9214

Merged
merged 4 commits into from
May 28, 2024

Conversation

djsmith85
Copy link
Contributor

Type of change

- [ ] Bug fix
- [X] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Create new import page using popup-page & popup-header and popup-footer for the extension UI refresh.

Code changes

  • apps/browser/src/popup/app-routing.module.ts: Add route to only show based on extension refresh feature flag
  • apps/browser/src/tools/popup/settings/import/import-browser-v2.component.ts and apps/browser/src/tools/popup/settings/import/import-browser-v2.component.html:
    • Create import-browser-v2 component
    • Copy existing import-browser-component
    • Add popup-page and -header and -footer
    • Add missing imports as page is marked as standalone Fix no-floating-promise
    • Change to route OnSuccess to vault-settings instead of old settings-page

Screenshots

Before

import_before

After

import_after

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

Copy existing `import-browser`-component
Add `popup-page` and -`header` and -`footer`
Add missing imports as page is marked as standalone
Fix no-floating-promise
Change to route OnSuccess to `vault-settings` instead of old `settings`-page
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label May 16, 2024
Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 28.13%. Comparing base (34a766f) to head (7d80c75).

Files Patch % Lines
...pup/settings/import/import-browser-v2.component.ts 0.00% 15 Missing ⚠️
apps/browser/src/popup/app-routing.module.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9214      +/-   ##
==========================================
- Coverage   28.13%   28.13%   -0.01%     
==========================================
  Files        2378     2379       +1     
  Lines       70325    70341      +16     
  Branches    13193    13193              
==========================================
  Hits        19788    19788              
- Misses      48972    48988      +16     
  Partials     1565     1565              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented May 16, 2024

Logo
Checkmarx One – Scan Summary & Detailsf508159f-e072-4647-b7bc-4de365f84c04

No New Or Fixed Issues Found

@djsmith85 djsmith85 marked this pull request as ready for review May 24, 2024 15:51
@djsmith85 djsmith85 requested a review from a team as a code owner May 24, 2024 15:51
@djsmith85 djsmith85 removed the needs-qa Marks a PR as requiring QA approval label May 28, 2024
@djsmith85 djsmith85 merged commit 49b5984 into main May 28, 2024
25 of 26 checks passed
@djsmith85 djsmith85 deleted the tools/pm-7239/import-page-ui-refresh branch May 28, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants