Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Push Subscription Management Proof #800

Draft
wants to merge 2 commits into
base: main-ose
Choose a base branch
from

Conversation

ArnyminerZ
Copy link
Member

No description provided.

@ArnyminerZ ArnyminerZ added the enhancement New feature or request label May 18, 2024
@rfc2822 rfc2822 closed this May 25, 2024
@rfc2822 rfc2822 deleted the push-subscription branch May 25, 2024 19:33
@rfc2822 rfc2822 restored the push-subscription branch May 30, 2024 11:02
@rfc2822 rfc2822 reopened this May 30, 2024
@rfc2822
Copy link
Member

rfc2822 commented Jun 2, 2024

So now that we have a proof 😃 we should do this properly. The first and most important issue I see now is that we when syncable collections change, the PushRegistrationWorker has to be enqueued. My suggestion is:

  1. Make sure that all collection DB access (CollectionDao) is done using DavCollectionRepository.
  2. Now we have a centralized location that is responsible for collection changes. So we can add observer functionality that allows observer to be notified about changes in collections.
  3. Add an observer that listens for changes in syncable collections and enqueues the worker.

What do you think of it? Or do you think there's an easier / better solution?

If we use this solution, I suggest to create a separate issue/PR for the observer and then only do point 3 in this PR.

…in UI

Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

None yet

3 participants