-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugin): added a couple of features to support typed-captions migration #20292
Open
GuiLeme
wants to merge
11
commits into
bigbluebutton:v3.0.x-release
Choose a base branch
from
GuiLeme:caption-as-plugin
base: v3.0.x-release
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+774
−177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nted most of the sidekickMenu
…nt and fixed wrong behaviors for the generic component sidekick content
This was referenced May 17, 2024
This pull request has conflicts ☹ |
akka-bbb-apps/src/main/scala/org/bigbluebutton/core/apps/caption/CaptionApp2x.scala
Outdated
Show resolved
Hide resolved
2 tasks
Quality Gate passedIssues Measures |
This pull request has conflicts ☹ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR does essentially 3 things:
Other than that, there are a few bugs found in the data-channel flow such as the remove entry function not working, those are already fixed by now.
Motivation
As mentioned in the title of this PR it is made to support the new typed-captions plugin.
More
Closely related to the plugin SDK PR bigbluebutton/bigbluebutton-html-plugin-sdk#82