Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ColorMaterial now uses LinearRgba #13336

Closed
wants to merge 1 commit into from
Closed

ColorMaterial now uses LinearRgba #13336

wants to merge 1 commit into from

Conversation

andristarr
Copy link
Contributor

@andristarr andristarr commented May 12, 2024 •
edited

Objective

ColorMaterial stores a LinearRgba instead of a Color

Fixes #13212

@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Usability A simple quality-of-life change that makes Bevy easier to use S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels May 13, 2024
alice-i-cecile
alice-i-cecile requested changes May 13, 2024
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in the linked issue, I actually made a mistake in the issue. We just need to change the type of StandardMaterial::emissive. ColorMaterial should be left alone here.

@andristarr
Copy link
Contributor Author

I will open a separate PR and drop this.

@andristarr
Copy link
Contributor Author

Closing this in favor of #13352

@andristarr andristarr closed this May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile requested changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Usability A simple quality-of-life change that makes Bevy easier to use S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

StandardMaterial::emissive field should use LinearRgba
2 participants
@andristarr @alice-i-cecile